Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DynProverImpl to ProverServer #871

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Rename DynProverImpl to ProverServer #871

merged 4 commits into from
Sep 13, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Sep 13, 2023

No description provided.

@flaub flaub self-assigned this Sep 13, 2023
@github-actions
Copy link

Benchmark for Linux-cuda 19ecc3a

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.10ms 5.0±0.10ms -1.96%
fib/100/prove 1481.6±18.57ms 705.6±5.56ms -52.38%
fib/100/total 1404.6±22.03ms 711.2±4.18ms -49.37%
fib/1000/execute 5.6±0.09ms 5.6±0.11ms 0.00%
fib/1000/prove 1440.1±35.54ms 739.4±5.72ms -48.66%
fib/1000/total 1415.1±19.78ms 746.8±4.17ms -47.23%
fib/10000/execute 11.3±0.15ms 11.2±0.10ms -0.88%
fib/10000/prove 4.7±0.03s 3.0±0.01s -36.17%
fib/10000/total 4.7±0.03s 3.1±0.02s -34.04%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal 19ecc3a

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.07ms 2.8±0.12ms 0.00%
fib/100/prove 801.3±3.43ms 801.2±5.10ms -0.01%
fib/100/total 832.2±6.17ms 831.6±6.96ms -0.07%
fib/1000/execute 3.1±0.05ms 3.1±0.15ms 0.00%
fib/1000/prove 823.7±5.29ms 821.4±5.50ms -0.28%
fib/1000/total 847.2±5.91ms 846.9±5.10ms -0.04%
fib/10000/execute 6.0±0.06ms 5.9±0.17ms -1.67%
fib/10000/prove 3.1±0.01s 3.1±0.01s 0.00%
fib/10000/total 3.1±0.01s 3.1±0.01s 0.00%

@flaub flaub enabled auto-merge (squash) September 13, 2023 18:51
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There's probably some room for more detailed docs on what this is, but that's an 0.19 problem IMO (certainly that's how I've been treating API client/server docs which are very much incomplete).

@flaub flaub disabled auto-merge September 13, 2023 18:55
@flaub flaub enabled auto-merge (squash) September 13, 2023 18:59
@github-actions
Copy link

Benchmark for Linux-cuda 53b3a8d

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.11ms 5.1±0.08ms 0.00%
fib/100/prove 710.3±7.47ms 656.1±1.30ms -7.63%
fib/100/total 708.9±6.71ms 662.7±1.85ms -6.52%
fib/1000/execute 5.7±0.07ms 5.6±0.09ms -1.75%
fib/1000/prove 740.0±4.70ms 688.5±1.97ms -6.96%
fib/1000/total 749.2±5.42ms 694.1±1.86ms -7.35%
fib/10000/execute 11.4±0.11ms 11.3±0.13ms -0.88%
fib/10000/prove 2.9±0.01s 2.6±0.01s -10.34%
fib/10000/total 2.9±0.01s 2.6±0.01s -10.34%

Benchmark for Linux-default 53b3a8d

Click to hide benchmark
Test Base PR %
fib/100/execute 4.8±0.14ms 4.7±0.15ms -2.08%
fib/100/prove 2.6±0.54s 1860.5±387.60ms -28.44%
fib/100/total 2.4±0.32s 2.1±0.19s -12.50%
fib/1000/execute 5.5±0.34ms 5.2±0.11ms -5.45%
fib/1000/prove 4.2±1.49s 2.4±0.21s -42.86%
fib/1000/total 2.5±0.47s 2.2±0.26s -12.00%
fib/10000/execute 12.2±1.57ms 9.8±0.13ms -19.67%
fib/10000/prove 7.2±0.45s 7.0±0.31s -2.78%
fib/10000/total 7.5±0.43s 7.2±0.52s -4.00%

Benchmark for macOS-default 53b3a8d

Click to hide benchmark
Test Base PR %
fib/100/execute 2.9±0.21ms 2.9±0.12ms 0.00%
fib/100/prove 3.6±0.06s 3.5±0.05s -2.78%
fib/100/total 3.5±0.03s 3.5±0.03s 0.00%
fib/1000/execute 3.1±0.05ms 3.0±0.06ms -3.23%
fib/1000/prove 3.6±0.08s 3.5±0.04s -2.78%
fib/1000/total 3.6±0.08s 3.6±0.03s 0.00%
fib/10000/execute 5.9±0.15ms 5.9±0.06ms 0.00%
fib/10000/prove 14.5±0.31s 14.3±0.16s -1.38%
fib/10000/total 14.4±0.14s 14.4±0.16s 0.00%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@flaub flaub merged commit 05924f1 into main Sep 13, 2023
20 checks passed
@flaub flaub deleted the flaub/rename branch September 13, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants