Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional documentation on reproducible builds #872

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

heavypackets
Copy link
Contributor

The PR adds deterministic build motivation and additional details on to the risczero build docs, including a link to install the Docker dependency on desktops.

This resolves #867.

Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good up to one comment on the ELFs

risc0/cargo-risczero/README.md Outdated Show resolved Hide resolved
risc0/cargo-risczero/README.md Outdated Show resolved Hide resolved
@heavypackets
Copy link
Contributor Author

Updated to reflect new risczero build output.

tzerrell and others added 2 commits September 13, 2023 12:46
Co-authored-by: Frank Laub <flaub@risc0.com>
@flaub flaub enabled auto-merge (squash) September 13, 2023 19:56
@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@flaub flaub merged commit 1551429 into main Sep 13, 2023
20 checks passed
@flaub flaub deleted the reproducible-builds-v0.18 branch September 13, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.18 Document reproducible builds / cargo risczero build changes
3 participants