Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum-Relay: fix empty journal on dev-mode #883

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Ethereum-Relay: fix empty journal on dev-mode #883

merged 4 commits into from
Sep 15, 2023

Conversation

capossele
Copy link
Contributor

@capossele capossele commented Sep 15, 2023 •
edited

  • Return the journal within a snark receipt when using the bonsai-mock-rest-api
  • Add local e2e test of the relay on CI

mothran
mothran approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@mothran mothran left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this warrants a version bump on 0.18? We could bump the bonsai-ethereum-relay crate pointer in bonsai-foundry-template to a specific commit instead once this merges.

@capossele
Copy link
Contributor Author

Yeah I think just bumping the bonsai-ethereum-relay crate pointer in bonsai-foundry-template should be enough for now.

@capossele capossele merged commit 4652f9c into main Sep 15, 2023
16 checks passed
@capossele capossele deleted the capossele/fix-dev-relay-empty-journal branch September 15, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mothran mothran mothran approved these changes

@nategraf nategraf Awaiting requested review from nategraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@capossele @mothran