-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added get_version to zkvm / bonsai version check #899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for Linux-cuda 059838aClick to hide benchmark
Benchmark for Linux-default 059838aClick to hide benchmark
Benchmark for macOS-default 059838aClick to hide benchmark
Benchmark for macOS-metal
|
Benchmark for Linux-cuda af9fadeClick to hide benchmark
Benchmark for Linux-default af9fadeClick to hide benchmark
Benchmark for macOS-default
Benchmark for macOS-metal
|
Benchmark for Linux-cuda 25f8e78Click to hide benchmark
Benchmark for Linux-default 25f8e78Click to hide benchmark
Benchmark for macOS-default 25f8e78Click to hide benchmark
Benchmark for macOS-metal 25f8e78Click to hide benchmark
|
flaub
approved these changes
Sep 21, 2023
Benchmark for Linux-cuda 5c84f5aClick to hide benchmark
Benchmark for Linux-default 5c84f5aClick to hide benchmark
Benchmark for macOS-default 5c84f5aClick to hide benchmark
Benchmark for macOS-metal
|
Benchmark for Linux-cuda d3a71acClick to hide benchmark
Benchmark for Linux-default
Benchmark for macOS-default d3a71acClick to hide benchmark
Benchmark for macOS-metal
|
tzerrell
approved these changes
Sep 25, 2023
Benchmark for Linux-cuda f6bb120Click to hide benchmark
Benchmark for Linux-default
Benchmark for macOS-default
Benchmark for macOS-metal f6bb120Click to hide benchmark
|
Benchmark for Linux-cuda f673c54Click to hide benchmark
Benchmark for Linux-default
Benchmark for macOS-default f673c54Click to hide benchmark
Benchmark for macOS-metal
|
Benchmark for Linux-cuda 52822f9Click to hide benchmark
Benchmark for Linux-default
Benchmark for macOS-default 52822f9Click to hide benchmark
Benchmark for macOS-metal
|
Benchmark for Linux-cuda 8e53ad2Click to hide benchmark
Benchmark for Linux-default 8e53ad2Click to hide benchmark
Benchmark for macOS-default
Benchmark for macOS-metal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
get_version()
method into therisc0-zkvm
crate to support version checking between bonsai and local clients. Additionally we now include ax-risc0-version
http header on requests to the Bonsai API to provide server side validation of the clients local zkvm version.Finally I refactors some of the HTTP header keys into exported values for other layers to reuse safely.
TODO:
/get_version
Bonsai REST routes