Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional Bonsai docs to default_prover #904

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Conversation

mothran
Copy link
Contributor

@mothran mothran commented Sep 25, 2023

This PR expands on the docs in places where we depend on external inputs like BONSAI_API_URL and BONSAI_API_KEY env vars to make it more clear their relationship to the selected prover.

@github-actions
Copy link

Benchmark for Linux-cuda 403d766

Click to hide benchmark
Test Base PR %
fib/100/execute 5.3±0.13ms 5.2±0.17ms -1.89%
fib/100/prove 715.7±4.16ms 697.8±2.89ms -2.50%
fib/100/total 718.4±3.96ms 703.3±4.83ms -2.10%
fib/1000/execute 5.8±0.16ms 5.8±0.11ms 0.00%
fib/1000/prove 745.8±3.13ms 732.2±2.97ms -1.82%
fib/1000/total 752.2±4.89ms 739.2±3.43ms -1.73%
fib/10000/execute 12.0±0.15ms 11.9±0.23ms -0.83%
fib/10000/prove 2.9±0.01s 2.8±0.01s -3.45%
fib/10000/total 3.0±0.02s 2.8±0.01s -6.67%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 403d766

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.10ms 2.7±0.10ms -3.57%
fib/100/prove 3.6±0.04s 3.6±0.05s 0.00%
fib/100/total 3.7±0.06s 3.6±0.04s -2.70%
fib/1000/execute 3.1±0.06ms 3.0±0.09ms -3.23%
fib/1000/prove 3.7±0.08s 3.7±0.05s 0.00%
fib/1000/total 3.7±0.09s 3.6±0.05s -2.70%
fib/10000/execute 6.1±0.05ms 5.9±0.11ms -3.28%
fib/10000/prove 15.1±0.08s 15.0±0.13s -0.66%
fib/10000/total 15.1±0.23s 15.0±0.09s -0.66%

Benchmark for macOS-metal 403d766

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.06ms 2.8±0.11ms 0.00%
fib/100/prove 800.5±5.49ms 795.4±6.96ms -0.64%
fib/100/total 824.4±4.44ms 824.3±5.18ms -0.01%
fib/1000/execute 3.1±0.04ms 3.0±0.18ms -3.23%
fib/1000/prove 822.2±10.32ms 817.8±2.71ms -0.54%
fib/1000/total 847.0±5.70ms 841.4±4.72ms -0.66%
fib/10000/execute 6.0±0.05ms 6.0±0.10ms 0.00%
fib/10000/prove 3.1±0.02s 3.1±0.01s 0.00%
fib/10000/total 3.1±0.01s 3.1±0.01s 0.00%

Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

risc0/zkvm/src/host/client/prove/bonsai.rs Outdated Show resolved Hide resolved
mothran and others added 2 commits September 25, 2023 18:36
Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>
Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>
@github-actions
Copy link

Benchmark for Linux-cuda f437c07

Click to hide benchmark
Test Base PR %
fib/100/execute 5.9±0.63ms 5.6±0.50ms -5.08%
fib/100/prove 870.3±35.26ms 681.0±2.01ms -21.75%
fib/100/total 769.5±8.41ms 686.2±4.26ms -10.83%
fib/1000/execute 6.1±0.12ms 5.9±0.18ms -3.28%
fib/1000/prove 904.6±83.60ms 714.2±4.19ms -21.05%
fib/1000/total 821.0±12.32ms 714.6±2.46ms -12.96%
fib/10000/execute 12.0±0.08ms 11.9±0.19ms -0.83%
fib/10000/prove 3.4±0.02s 2.6±0.01s -23.53%
fib/10000/total 3.4±0.01s 2.6±0.01s -23.53%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default f437c07

Click to hide benchmark
Test Base PR %
fib/100/execute 2.9±0.21ms 2.7±0.12ms -6.90%
fib/100/prove 3.7±0.05s 3.6±0.06s -2.70%
fib/100/total 3.6±0.08s 3.6±0.04s 0.00%
fib/1000/execute 3.1±0.06ms 3.0±0.12ms -3.23%
fib/1000/prove 3.7±0.05s 3.7±0.05s 0.00%
fib/1000/total 3.7±0.07s 3.7±0.06s 0.00%
fib/10000/execute 6.1±0.13ms 5.9±0.09ms -3.28%
fib/10000/prove 15.1±0.14s 15.1±0.10s 0.00%
fib/10000/total 15.1±0.11s 15.0±0.09s -0.66%

Benchmark for macOS-metal f437c07

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.08ms 2.8±0.10ms 0.00%
fib/100/prove 802.0±5.53ms 801.8±3.32ms -0.02%
fib/100/total 832.7±7.10ms 825.3±3.83ms -0.89%
fib/1000/execute 3.1±0.04ms 3.1±0.10ms 0.00%
fib/1000/prove 820.3±7.60ms 820.2±3.85ms -0.01%
fib/1000/total 850.2±6.31ms 840.9±7.33ms -1.09%
fib/10000/execute 6.1±0.07ms 6.0±0.07ms -1.64%
fib/10000/prove 3.1±0.01s 3.1±0.02s 0.00%
fib/10000/total 3.1±0.01s 3.1±0.01s 0.00%

@flaub flaub enabled auto-merge (squash) September 26, 2023 18:20
@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 9e106bc

Click to hide benchmark
Test Base PR %
fib/100/execute 2.9±0.22ms 2.8±0.10ms -3.45%
fib/100/prove 3.7±0.05s 3.6±0.07s -2.70%
fib/100/total 3.6±0.06s 3.6±0.06s 0.00%
fib/1000/execute 3.0±0.10ms 2.9±0.09ms -3.33%
fib/1000/prove 3.7±0.05s 3.7±0.08s 0.00%
fib/1000/total 3.7±0.05s 3.6±0.06s -2.70%
fib/10000/execute 6.1±0.10ms 6.1±0.13ms 0.00%
fib/10000/prove 15.0±0.18s 15.0±0.07s 0.00%
fib/10000/total 15.1±0.17s 15.1±0.20s 0.00%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@flaub flaub merged commit d544ff8 into main Sep 26, 2023
20 checks passed
@flaub flaub deleted the parker/def-prover-docs branch September 26, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants