-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(relay): Retry upon TCP connection error #954
Conversation
("SUCCEEDED", true) => { | ||
return Poll::Ready(Ok(this.pending_proof_id.clone())) | ||
} | ||
("SUCCEEDED", false) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah if this happens its a hard error and bonsai has something very wrong with it haha.
@@ -51,6 +52,7 @@ validator = { version = "0.16", features = ["derive"] } | |||
bincode = "1" | |||
bytemuck = "1.13" | |||
risc0-zkvm-methods = { path = "../../risc0/zkvm/methods", default-features = false } | |||
rstest = "0.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.rs/rstest/latest/rstest/ interesting! TIL, @flaub this looks like a interesting library for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Solves #842