Force ICache to generated named memories #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/scala/ifu/icache.scala
Outdated
| @@ -287,11 +287,12 @@ class ICacheModule(outer: ICache) extends ICacheBaseModule(outer) | |||
| else (nSets * refillCycles) | |||
| val dataArraysB0 = Seq.fill(nWays) { SyncReadMem(ramDepth, UInt(dECC.width(wordBits/nBanks).W)) } | |||
There was a problem hiding this comment.
Currently, it looks like the if determines whether to use the dataArraysB* or the dataArrays. To me it makes more sense that these SyncReadMem's are within the if statement blocks. Have you tried doing something like...
val dataArrays = Seq.tabulate(nWays) { SyncReadMem(nSets * refillCycles, UInt(dECC.width(wordBits).W)).suggestName("dataArrayWay" + _.toString) }
jerryz123
force-pushed
the
named_ic_mem
branch
from
c48bbb9
to
8365c58
Compare
jerryz123
force-pushed
the
named_ic_mem
branch
from
8365c58
to
f720e99
Compare
abejgonzalez
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.