Rename Refactor #304
Merged
Rename Refactor #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkorpan
requested review from
abejgonzalez,
jerryz123 and
ccelio
and removed request for
abejgonzalez
ccelio
approved these changes
Jun 22, 2019
There was a problem hiding this comment.
At a high-level, my only real request is that you think hard about adding asserts to the rename logic (esp. the freelist and maptable). I was too lazy and complacent to do so before, but I think now is a good time to do so while the logic is fresh in your mind.
jerryz123
approved these changes
Jun 22, 2019
bkorpan
commented
Jun 22, 2019
… a problem in testing because all unique instructions currently perform a flush upon commit.
… return an already-free physical register.
bkorpan
force-pushed
the
rename-refactor-rebased
branch
from
3243b6b
to
ccb4c39
Compare
…ow, as it may have a future use.
bkorpan
force-pushed
the
rename-refactor-rebased
branch
4 times, most recently
from
7dece28
to
ee7a548
Compare
ccelio
reviewed
Jun 24, 2019
bkorpan
force-pushed
the
rename-refactor-rebased
branch
from
ee7a548
to
2ffe128
Compare
…cate mapping assert.
…se where a branch at the rob tail could mispredict during the first cycle of rollback. This bug was also present prior to this refactor. This is the best fix because it should not affect the speed of the branch/exception kill paths, and might also enable a future QoR tweak.
bkorpan
force-pushed
the
rename-refactor-rebased
branch
from
2ffe128
to
b698b0a
Compare
|
This should be ready to go now. I'll do another check that it boots Fedora after this big round of tweaks. |
|
Boots Fedora fine with 2, 3, and even 4 -wide pipelines. |
abejgonzalez
approved these changes
Jun 30, 2019
jerryz123
pushed a commit
that referenced
this pull request
Mar 11, 2021
Add a specific toolchain `env.sh`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: rtl refactoring
Development Phase: implementation
Release Notes
Rewrote rename structures more concisely and refactored the decode/rename/dispatch pipeline control logic.