Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RVC Expansion QoR Tweak #335

Merged
merged 2 commits into from
Jul 19, 2019
Merged

RVC Expansion QoR Tweak #335

merged 2 commits into from
Jul 19, 2019

Conversation

bkorpan
Copy link
Contributor

@bkorpan bkorpan commented Jul 15, 2019

Related issue:

Type of change: other enhancement

Impact: rtl refactoring

Development Phase: implementation

Release Notes
The RVC expansion logic decides whether there was an 'edge instruction' more efficiently.

jerryz123
jerryz123 approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much more elegant than a PC comparison

abejgonzalez
abejgonzalez approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 75dc3ff into master Jul 19, 2019
@abejgonzalez abejgonzalez deleted the rvc-qor-tweak branch July 19, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abejgonzalez abejgonzalez abejgonzalez approved these changes

@jerryz123 jerryz123 jerryz123 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkorpan @abejgonzalez @jerryz123