Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rocc] Remove debug_inst #342

Merged
merged 1 commit into from
Jul 25, 2019
Merged

[rocc] Remove debug_inst #342

merged 1 commit into from
Jul 25, 2019

Conversation

bkorpan
Copy link
Contributor

@bkorpan bkorpan commented Jul 18, 2019

Type of change: other enhancement

Impact: rtl refactoring

Development Phase: implementation

Release Notes
Use inst instead of debug_inst to get the RoCC instruction. Should prevent debug_inst from being propagated through the fetch buffer post synthesis.

@abejgonzalez
Copy link
Contributor

LGTM. Just to be clear the debug signals should not be used for logic decisions throughout the core, right?

@jerryz123
Copy link
Contributor

This fixes that, originally debug_inst was being used as a logic signal to pass stuff into decode.

@bkorpan bkorpan merged commit 1cec3fc into master Jul 25, 2019
@bkorpan bkorpan deleted the rocc-debug-inst branch February 6, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants