Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Refactor CfiTypes constants #393

Merged
merged 1 commit into from
Sep 24, 2019
Merged

[core] Refactor CfiTypes constants #393

merged 1 commit into from
Sep 24, 2019

Conversation

jerryz123
Copy link
Contributor

This more closely matches the organization of constants in the repo.

@@ -68,6 +68,7 @@ trait IQType
val IQT_MFP = 6.U(IQT_SZ.W)
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space? Looks like the rest of the file only has single spaces.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the space. LGTM.

@jerryz123 jerryz123 merged commit 783b936 into master Sep 24, 2019
@jerryz123 jerryz123 deleted the cfifix branch October 18, 2019 18:41
jerryz123 pushed a commit that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants