-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FireSim CI #409
FireSim CI #409
Conversation
Stopping this from getting merged to figure out why copying things from the Fedora instance is not working (BOOM works with Fedora... just copying the uartlog is breaking (this happens on both BOOM and Rocket)) |
The copying is a FireSim bug that is being tracked here: firesim/firesim#329. Until then, this PR works and things are tested properly. |
5708324
to
101301c
Compare
@@ -1,2 +1 @@ | |||
0f34a22c5383284d62fdd594e882e321c4ef9cfa | |||
|
|||
6f1a53a2f3e43c8444a308e002a611fcfb995bcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CI hash is on pointing to the firesim-bump
branch of Chipyard, but will be updated once the release happens.
.circleci/README.md
Outdated
|
||
If the workloads fail to run AND the manager instance stops, you can still run tests again: | ||
- Re-boot the instance (note: the IP address has changed) | ||
- Add to the CircleCI UI `$AWS_IP_ADDR_OVERRIDE` with the new IP address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use case for this? When would someone want to rerun this way after a failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was used to debug why the manager was failing and instead of spawning a new manager (which takes O(30min)) you could just reuse the previous manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what does this mean "Add to the CircleCI UI". Are you referring to the config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill clarify this a bit. I mean within the CircleCI Web UI enter "Project Settings" and under the "Environment Variables" tab add the environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill update once CI is done so that the tests can run to completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow TIL that feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a project-wide global setting, or can you add it per-run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its for the entire project.
Can you squash some of the more trivial commits here, and also prefix them all with [ci]? Otherwise looks fine. I assume the green check means it works |
Don't hardcode version in docs conf.py, let readthedocs fill it in
Related issue: Fixes #364
Type of change: new feature
Impact: no rtl change
Development Phase: implementation
Release Notes
This PR adds FireSim (https://fires.im/) FPGA integration to CI to check both Buildroot and Fedora Linux boot on LargeBoom. This uses Chipyard to initialize and setup FireSim. FireSim runs are started at 0:00am on Thursdays (weekly) only on the
master
branch. In order to start the FPGA image build one of the BOOM developers must click the "aws-approval" button in the CircleCI UI.This PR also changes the CI significantly by using CircleCI "commands" to create job "functions" which can be reused and pipeline parameters that can determine how to manage the workflow.