Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -m[no-][scalar|vector]-strict-align #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kito-cheng
Copy link
Collaborator

Add two new option -m[no-]scalar-strict-align for alias of -m[no-]-strict-align and -m[no-][vector]-strict-align for vector misaligned access.

@kito-cheng
Copy link
Collaborator Author

@kito-cheng
Copy link
Collaborator Author

kito-cheng commented May 29, 2024

@kito-cheng kito-cheng requested a review from cmuellner May 29, 2024 08:58
@topperc
Copy link
Contributor

topperc commented Jun 6, 2024

CC @preames

Copy link

@nick-knight nick-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shared my opinion on a related proposal here: riscv-non-isa/riscv-c-api-doc#73 (comment)

I don't personally plan to use these flags, so I'm OK if it remains GCC-specific behavior, but I won't fight it if others in the community think it's actually useful.

README.mkd Outdated Show resolved Hide resolved
Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but has a dependency for #49.

topperc added a commit to topperc/llvm-project that referenced this pull request Jun 10, 2024
…. Alias -m[no-]strict-align to scalar.

__riscv_misaligned_fast will be set based on -mno-scalar-strict-align
or -mno-strict-align.

This matches the direction gcc is proposing.

See
riscv-non-isa/riscv-c-api-doc#73
riscv-non-isa/riscv-toolchain-conventions#49
riscv-non-isa/riscv-toolchain-conventions#50
riscv-non-isa/riscv-c-api-doc#80
@kito-cheng kito-cheng force-pushed the kitoc/opt-strict-align branch 2 times, most recently from 090aedc to 79008be Compare June 13, 2024 07:04
@kito-cheng
Copy link
Collaborator Author

Changes:

  • Update the description to match -mstrict-align affect both scalar and vector.

README.mkd Outdated Show resolved Hide resolved
Base automatically changed from kitoc/opt-strict-align to main June 28, 2024 06:47
Add two new option `-m[no-]scalar-strict-align` for alias of `-m[no-]-strict-align`
and `-m[no-][vector]-strict-align` for vector misaligned access.
@kito-cheng
Copy link
Collaborator Author

Changes:

  • Drop redundant t in the line of end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants