Add `vcreate` for non-tuple types and `vundefine` for tuple types #288

eopXD · 2023-10-25T13:55:40Z

Although this use case [0] is SIMD style and not that ideal for RVV, they can benefit from this syntax sugar.
On the other hand, vundefined for tuple types will help declaration under -Winitialized to avoid using a vcreate with numbers of vundefined non-tuple members in it.

Resolves #286.

For the vcreate addition, variants of an assembling a fractional LMUL type with smaller fractional LMUL, and assembling LMUL>1 type with fractional LMUL is omitted because they are unlikely use cases.

LLVM implementations of the added intrinsics are:

dzaima · 2023-10-25T14:37:07Z

Fractional LMUL inputs should be completely forbidden just like they are with register vset_v_ and vget_v_, as they'd need to reference fractional parts of a single register by a register, which is impossible.

zhongjuzhe · 2023-10-25T22:40:51Z

All fractional intrinsics should be removed.

For example:

vint16m1_t test_vcreate_v_i16mf4_i16m1(vint16mf4_t v0, vint16mf4_t v1,
vint16mf4_t v2, vint16mf4_t v3) {
return __riscv_vcreate_v_i16mf4_i16m1(v0, v1, v2, v3);
}

They are not like tuple type vint16mf4x4_t.

vint16m1_t occupies 1 register wheras vint16mf4x4_t occupies 4 registers.

kito-cheng · 2023-10-26T02:36:47Z

I could imagine the fraction LMUL version is implement-able but complicate and very low performance (vmerge and/or vslide), so I am +1 on removing that.

Construction associating any fractional LMUL type is omitted because it will be unlikely cases and we are adding a syntax sugar here. Signed-off-by: eop Chen <eop.chen@sifive.com>

…-autogen-doc)

…ogen-test)

An undefined value for tuple types allows us to avoid uninitialized value during variable declaration. Signed-off-by: eop Chen <eop.chen@sifive.com>

…-autogen-doc)

…ogen-test)

riscv-non-isa/rvv-intrinsic-doc#288

kito-cheng

LGTM

riscv-non-isa/rvv-intrinsic-doc#288

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test.

riscv-non-isa/rvv-intrinsic-doc#288

@vundefined

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (vundefined): Add vundefine intrinsics for tuple types. * config/riscv/riscv-vector-builtins.cc: Ditto. * config/riscv/vector.md (@vundefined<mode>): Ditto. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_vundefined.c: New test. (cherry picked from commit 084ea7e)

riscv-non-isa/rvv-intrinsic-doc#288 gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Expand non-tuple intrinsics. * config/riscv/riscv-vector-builtins-functions.def (vcreate): Define non-tuple intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct vcreate_def): Ditto. * config/riscv/riscv-vector-builtins.cc: Add arg types. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/base/tuple_create.c: Rename to vcreate.c. * gcc.target/riscv/rvv/base/vcreate.c: New test. (cherry picked from commit d508a94)

eopXD requested review from rofirrim, kito-cheng and topperc October 25, 2023 13:55

eopXD added 6 commits October 26, 2023 01:10

Add vcreate intrinsics for non-tuple types

b6f68f5

Construction associating any fractional LMUL type is omitted because it will be unlikely cases and we are adding a syntax sugar here. Signed-off-by: eop Chen <eop.chen@sifive.com>

[Auto-gen] Update documents under ../auto-generated. (make git-commit…

7424816

…-autogen-doc)

[Auto-gen] Update tests under ../auto-generated. (make git-commit-aut…

e778051

…ogen-test)

Add vundefined intrinsics for tuple types

3bad981

An undefined value for tuple types allows us to avoid uninitialized value during variable declaration. Signed-off-by: eop Chen <eop.chen@sifive.com>

[Auto-gen] Update documents under ../auto-generated. (make git-commit…

d2cf790

…-autogen-doc)

[Auto-gen] Update tests under ../auto-generated. (make git-commit-aut…

5a232a2

…ogen-test)

eopXD force-pushed the eopc/vcreate-for-non-tuple branch from 40ca0de to 5a232a2 Compare October 26, 2023 16:40

eopXD changed the title ~~Add vcreate for non-tuple types~~ Add vcreate for non-tuple types and vundefine for tuple types Oct 26, 2023

eopXD added a commit to eopXD/llvm-project that referenced this pull request Oct 26, 2023

[Clang][RISCV] Add vundefine intrinsics for tuple types

3098b63

riscv-non-isa/rvv-intrinsic-doc#288

This was referenced Oct 26, 2023

[Clang][RISCV] Add vundefine intrinsics for tuple types llvm/llvm-project#70354

Merged

[Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types llvm/llvm-project#70355

Merged

kito-cheng approved these changes Oct 30, 2023

View reviewed changes

eopXD merged commit a798393 into main Oct 30, 2023
9 checks passed

eopXD deleted the eopc/vcreate-for-non-tuple branch October 30, 2023 07:03

eopXD added a commit to llvm/llvm-project that referenced this pull request Oct 30, 2023

[Clang][RISCV] Add vundefine intrinsics for tuple types (#70354)

e9ff4e4

riscv-non-isa/rvv-intrinsic-doc#288

eopXD added a commit to llvm/llvm-project that referenced this pull request Oct 31, 2023

[Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (#70355)

d4a885f

riscv-non-isa/rvv-intrinsic-doc#288

nick-knight mentioned this pull request Nov 11, 2023

Fixes for the specification #292

Merged

qihangkong pushed a commit to rvgpu/llvm that referenced this pull request Apr 18, 2024

[Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types

11e35fd

riscv-non-isa/rvv-intrinsic-doc#288

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `vcreate` for non-tuple types and `vundefine` for tuple types #288

Add `vcreate` for non-tuple types and `vundefine` for tuple types #288

eopXD commented Oct 25, 2023 •

edited

Loading

dzaima commented Oct 25, 2023

zhongjuzhe commented Oct 25, 2023

kito-cheng commented Oct 26, 2023

kito-cheng left a comment

Add vcreate for non-tuple types and vundefine for tuple types #288

Add vcreate for non-tuple types and vundefine for tuple types #288

Conversation

eopXD commented Oct 25, 2023 • edited Loading

dzaima commented Oct 25, 2023

zhongjuzhe commented Oct 25, 2023

kito-cheng commented Oct 26, 2023

kito-cheng left a comment

Choose a reason for hiding this comment

Add `vcreate` for non-tuple types and `vundefine` for tuple types #288

Add `vcreate` for non-tuple types and `vundefine` for tuple types #288

eopXD commented Oct 25, 2023 •

edited

Loading