Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what we mean by float and double #324

Merged
merged 1 commit into from
May 7, 2024

Conversation

rofirrim
Copy link
Collaborator

Address #322

@rofirrim rofirrim requested a review from eopXD April 29, 2024 14:45
@@ -431,6 +431,8 @@ Types with subscript "^\*^" are available when `ELEN >= 64` (that is, unavailabl
[[floating-point-type]]
=== Floating-point types

NOTE: This specification uses `_Float16` to designate IEEE-754 binary16, `float` to designate IEEE-754 binary32 and `double` to designate IEEE-754 binary64.
Copy link
Collaborator

@4vtomat 4vtomat May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need __bf16 for bfloat16?

Copy link
Collaborator

@nick-knight nick-knight May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BF16 was not part of the original vector extensions --- see #293. We will add this at a later date, once we get the base vector intrinsics ratified. Similarly for the vector crypto stuff --- see #234. Arguably, we could drop the FP16 stuff too, since Zvfh was ratified separately from V, but it has been in this spec for a long time (for historical reasons) and I don't support dropping it without good reason.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks @nick-knight !

Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@kito-cheng kito-cheng merged commit 61a7e82 into riscv-non-isa:main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants