[NFC] Make Generator class becomes ABC #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The following member functions will return NotImplemented if not implemented in derived classes to let user aware that the function call is not functioning - write() - write_title() - gen_prologue() - inst_group_prologue() - inst_group_epilogue() - post_gen() - The func function is set as abstract method, all the derived classes shoule have their own implementation - The original func implementation is copied to DocGenerator and APITestGenerator and replace the call of base func() implementation Signed-off-by: Jerry Zhang Jian <jerry.zhangjian@sifive.com>
kito-cheng
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following member functions will return NotImplemented if not implemented in derived classes to let user aware that the function call is not functioning
The func function is set as abstract method, all the derived classes shoule have their own implementation
The original func implementation is copied to DocGenerator and APITestGenerator and replace the call of base func() implementation