lib: Redirect unhandled traps from non-M modes to S mode #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we didn't handle a trap with one of the available handlers, check if the trap comes from S or U mode and redirect it to S mode's trap handler. Signed-off-by: Nick Kossifidis <mick@ics.forth.gr>
avpatel
requested changes
Apr 19, 2019
| @@ -178,6 +179,8 @@ void sbi_trap_handler(struct sbi_trap_regs *regs, | |||
| msg = "ecall handler failed"; | |||
| break; | |||
| default: | |||
| /* If the trap came from S or U mode, redirect it there */ | |||
| rc = sbi_trap_redirect(regs, scratch, regs->mepc, mcause, mtval); | |||
There was a problem hiding this comment.
This sbi_trap_redirect() call should under
if (((regs->mstatus & MSTATUS_MPP) >> MSTATUS_MPP_SHIFT) != PRV_M) {
...
}
There was a problem hiding this comment.
From sbi_trap_redirect:
/* Sanity check on previous mode */
prev_mode = (regs->mstatus & MSTATUS_MPP) >> MSTATUS_MPP_SHIFT;
if (prev_mode != PRV_S && prev_mode != PRV_U)
return SBI_ENOTSUPP;
There was a problem hiding this comment.
Ahh yes, I forgot. We are already checking this in sbi_trap_redirect.
|
BTW, sorry for delayed response. We have updated docs/contributing.md to promote patches send via OpenSBI mailing list. In future, please prefer sending to OpenSBI mailing list. |
avpatel
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we didn't handle a trap with one of the available
handlers, check if the trap comes from S or U mode and
redirect it to S mode's trap handler.
Signed-off-by: Nick Kossifidis mick@ics.forth.gr