Fence revert #83
Closed
Fence revert #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 05602e2. Introducing a fence causes warm reset issue to reappear. Revert it for the time being.
All the non-boot harts run in a tight loop which may cause a heavy load on the memory bus. This may delay the boot hart to complete the cold boot process. Introduce few nop that will ease up the traffic. Signed-off-by: Atish Patra <atish.patra@wdc.com>
|
warm reset issue ??? |
|
Yes, some thing out-of-sync when we use "reset button" (warm boot) on SiFive Unleashed board. Although, cold-boot using power-on button works perfectly fine on SiFive Unleashed board. Refer, #65 We have few fixes in-place for warm boot (submitted by Atish) but the "fence rw,rw" patch is again causing warm boot issue to re-appear so for time-being we have reverted it. |
Merged
|
No need to merge this. I have raised another PR with fence revert and some additional required warm reset fix. |
|
Closing the PR as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.