Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded path to DTC breaks packaging #427

Closed
joelsherrill opened this issue Mar 21, 2020 · 3 comments
Closed

Hard-coded path to DTC breaks packaging #427

joelsherrill opened this issue Mar 21, 2020 · 3 comments

Comments

@joelsherrill
Copy link
Contributor

The RTEMS Project includes Spike in our package building system as part of a RISC-V toolset. The packaging tool (as is common) builds and installs into a temporary location which has a prefix before the ultimate intended prefix (e.g. /tmp/building/${prefix}). We package DTC with Spike so this results in the configure.ac probe configuring dtc to use a temporary directory, not the real install location.

IMO, hard coding a path like this makes spike sensitive to post build issues. If a user installs dtc in a directory like /usr/local/dtc-1.2 and /usr/local/dtc-1.4, spike is dependent on this and spike must be rebuilt to use a newer dtc.

I would suggest and am happy to implement that dtc be invoked as a simple program name without full path. The alternative is that there be a configure option to use the simple program name instead of the full path.

Please make a suggestion as to your preferred solution or implement it yourself. It appears to be fairly trivial to just set DTC to dtc in configure.ac and solve the problem from my perspective.

Thanks.

@aswaterman
Copy link
Collaborator

Sounds reasonable to me. Would you please make the PR?

@joelsherrill
Copy link
Contributor Author

Pull request created. Thanks for the quick feedback.

@aswaterman
Copy link
Collaborator

Thank you. Merged, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants