Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: remove I/O operation in RowSetBuilder #110

Closed
skyzh opened this issue Nov 5, 2021 · 3 comments · Fixed by #499
Closed

storage: remove I/O operation in RowSetBuilder #110

skyzh opened this issue Nov 5, 2021 · 3 comments · Fixed by #499
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@skyzh
Copy link
Member

skyzh commented Nov 5, 2021

... and we need a new RowSetWriter to write what's inside builder to the disk.

@skyzh
Copy link
Member Author

skyzh commented Feb 17, 2022

From my perspective, the RowsetBuilder should not contain any I/O related logic, and the logic like creating directory and flushing data should be moved to a separate module, maybe RowsetWriter? So that we won't need to create a directory even the rowset is still in memory.

Originally posted by @zzl200012 in #492 (comment)

From my perspective, the RowsetBuilder should not contain any I/O related logic, and the logic like creating directory and flushing data should be moved to a separate module, maybe RowsetWriter? So that we won't need to create a directory even the rowset is still in memory.

That's something I'd like to refactor :)

In fact, all I/O is done in flush_and_finish for RowSetBuilder. I plan to let the caller to decide whether to write these files or not, instead of doing all I/O inside the RowSetBuilder.

We already have a tracking issue for that #110

Originally posted by @skyzh in #492 (comment)

@skyzh skyzh added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2022
@zzl200012
Copy link
Member

That's fine. I will take a look this weekend.

@zzl200012 zzl200012 self-assigned this Feb 17, 2022
@skyzh
Copy link
Member Author

skyzh commented Feb 19, 2022

Oops, it seems that #499 has already fixed this by introducing a RowSet writer. cc @zzl200012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants