You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From my perspective, the RowsetBuilder should not contain any I/O related logic, and the logic like creating directory and flushing data should be moved to a separate module, maybe RowsetWriter? So that we won't need to create a directory even the rowset is still in memory.
From my perspective, the RowsetBuilder should not contain any I/O related logic, and the logic like creating directory and flushing data should be moved to a separate module, maybe RowsetWriter? So that we won't need to create a directory even the rowset is still in memory.
That's something I'd like to refactor :)
In fact, all I/O is done in flush_and_finish for RowSetBuilder. I plan to let the caller to decide whether to write these files or not, instead of doing all I/O inside the RowSetBuilder.
... and we need a new
RowSetWriter
to write what's inside builder to the disk.The text was updated successfully, but these errors were encountered: