refactor(storage): separate writing from builder. #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix compactor panic. Signed-off-by: arkbriar <arkbriar@gmail.com>
No need. I'll take a look at this PR next week :) |
zzl200012
reviewed
Feb 19, 2022
zzl200012
reviewed
Feb 19, 2022
|
Others LGTM! Let @skyzh have a more detailed review then. |
skyzh
approved these changes
Feb 21, 2022
src/storage/secondary/rowset/raw.rs
Outdated
|
|
||
| use crate::catalog::ColumnCatalog; | ||
|
|
||
| /// Raw columns. |
There was a problem hiding this comment.
What's the meaning of Raw? Better to name it as EncodedColumn or something?
There was a problem hiding this comment.
Intended to be "in raw bytes". "Encoded" is better as with different encoders we get different bytes.
I'll fix it.
…as an argument when flush. Signed-off-by: arkbriar <arkbriar@gmail.com>
…EncodedColumn' Signed-off-by: arkbriar <arkbriar@gmail.com>
auto-merge was automatically disabled
February 21, 2022 02:51
Head branch was pushed to by a user without write access
arkbriar
force-pushed
the
refactor/secondary-storage-rowset-writer
branch
from
4a5b4c2
to
089c8bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: arkbriar arkbriar@gmail.com
Separates the write logic from the rowset builder and also fixes the #493 .
close #110
close #493
I fix it by skipping the entire add rowset procedure. Not sure if it's legal in all circumstances, e.g. compact all rowsets in a table (empty and delete them all. Is it necessary to make sure as least one active rowset in the directory? @skyzh