fix(optimizer): support pushdown pk to storage scan #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems that |
|
fixed b/c we didn't insert data into the table |
|
... and obviously there are some sub-optimal plans 🤪 like two |
Yes, in CBO, if a table is empty, then any plan is possible because all of them have zero cost... |
wangrunji0408
approved these changes
Aug 21, 2023
| └── Scan | ||
| ├── table: t1 | ||
| ├── list: [ a, b ] | ||
| ├── filter: and { lhs: > { lhs: 0, rhs: a }, rhs: > { lhs: a, rhs: 1 } } |
There was a problem hiding this comment.
Seems that we should add some rules to rewrite this to false 🤔
Maybe:
rw!(""; "(and (> ?x ?a) (< ?x ?b))" => "false" if is_greater_than_or_equal("?a", "?b"))
Comment on lines
+54
to
+55
| Filter { cond: and { lhs: > { lhs: b, rhs: 1 }, rhs: > { lhs: a, rhs: 3 } }, cost: 15.1, rows: 1.25 } | ||
| └── Scan { table: t1, list: [ a, b ], filter: > { lhs: a, rhs: 1 }, cost: 10, rows: 5 } |
There was a problem hiding this comment.
ditto. a > 1 and a > 3 should be rewrited to a > 3.
Maybe:
rw!(""; "(and (> ?x ?a) (> ?x ?b))" => "(> ?x ?a)" if is_greater_than_or_equal("?a", "?b"))There was a problem hiding this comment.
will make it in a separate pull request
Signed-off-by: Alex Chi <iskyzh@gmail.com>
skyzh
force-pushed
the
skyzh/fix-pk-pushdown
branch
from
cd03496
to
f08b89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new rule that maps null to true so that storage filter on pk can be pushed down.