fix(optimizer): fix filter pushdown and range fold #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangrunji0408
approved these changes
Mar 21, 2024
src/planner/rules/expr.rs
Outdated
| &egraph[subst[v1]].data.constant, | ||
| &egraph[subst[v2]].data.constant, | ||
| ) { | ||
| (Some(d1), Some(d2)) => f(d1, d2), |
There was a problem hiding this comment.
Seems like the common condition std::mem::discriminant(d1) == std::mem::discriminant(d2) can be moved to here.
|
yep i'll handle these two pull requests on the weekends :) |
|
need rebasing + fix conflicts, I can help with that next weekend :) |
Signed-off-by: kysshsy <kysshsy@gmail.com>
kysshsy
force-pushed
the
fix-filter-pushdown
branch
from
b5bc662
to
2610031
Compare
|
rebase the commit, help me check the sql test result, thank you 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #794 #834 , add some new rules and change scan's default filter to true(this make it match with the "filter-scan" rule)