-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove async_trait from ExchangeSource #1463
Labels
Comments
lmatz
added
help wanted
Issues that need help from contributors
good first issue
Good for newcomers
labels
Mar 31, 2022
skyzh
changed the title
remove async_triat from ExchangeSource
remove async_trait from ExchangeSource
Mar 31, 2022
Hi @lmatz! May I try to resolve this issue? The intuition behind it seems similar to this tutorial: https://www.skyzh.dev/posts/articles/2022-01-31-gat-async-trait/ |
Sure! |
KivenChen
added a commit
to KivenChen/risingwave
that referenced
this issue
Jun 30, 2022
KivenChen
added a commit
to KivenChen/risingwave
that referenced
this issue
Jun 30, 2022
3 tasks
A PR has been created to solve this issue. PTAL #3586 |
lmatz
pushed a commit
that referenced
this issue
Jul 2, 2022
huangjw806
pushed a commit
that referenced
this issue
Jul 5, 2022
mergify bot
added a commit
that referenced
this issue
Jul 6, 2022
* fix(batch): remove async_trait from ExchangeSource(#1463) * fix(batch): remove async_trait from ExchangeSource(#1463) * fix(batch): [cfg(test)] scope problem * fix(batch): added license header for exchange_source.rs * refactor(storage): remove async_trait for MergeIteratorNext Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this issue
Aug 9, 2022
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this issue
Aug 9, 2022
…velabs#3673) * fix(batch): remove async_trait from ExchangeSource(risingwavelabs#1463) * fix(batch): remove async_trait from ExchangeSource(risingwavelabs#1463) * fix(batch): [cfg(test)] scope problem * fix(batch): added license header for exchange_source.rs * refactor(storage): remove async_trait for MergeIteratorNext Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
https://github.com/singularity-data/risingwave/blob/main/rust/rpc_client/src/compute_client.rs#L128-L132
take_data
gets frequently called and is on the critical path. We may need to remove the overhead ofasync_trait
.Same as what #1132 did.
The text was updated successfully, but these errors were encountered: