fix(expr): to_timestamp
should return timestamptz
#11018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #7780
Backward compatibility: The old
to_timestamp(varchar, varchar) -> timestamp
would not be generated by frontend, but is still accepted by backend, despite lacking the constant template optimization.Tested locally: (1) create a mview with
to_timestamp
on main branch; (2) kill the cluster, switch to PR branch, and start cluster; (3) query the mview, insert new rows to its upstream and query againGiven the initial request to support
to_timestamp
comes from superset, it is likely this expr is not used in a mview yet. If we do find it is necessary to optimize this legacy variant with constant template as well, we can refactorExprToTimestampConstTmpl
with generic.The following styling issues will be handled in a followup PR:
timezone
vstime_zone
to_timestamp1
->char_to_timestamptz
to_timestamp
->sec_to_timestamptz
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Types of user-facing changes
Release note
to_timestamp(input_string, format)
returnstimestamptz
, aligning with PostgreSQL.