Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): expose hummock pinned versions and snapshots via rw_catalog #12285

Merged
merged 1 commit into from Sep 13, 2023

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Sep 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

part of #8612

dev=> select * from rw_hummock_pinned_versions;
 worker_node_id | min_pinned_version_id 
----------------+-----------------------
              1 |                     5
(1 row)

dev=> select * from rw_hummock_pinned_snapshots;
 worker_node_id | min_pinned_snapshot_id 
----------------+------------------------
              2 |       5070940531195904
(1 row)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 added the user-facing-changes Contains changes that are visible to users label Sep 13, 2023
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang28 zwang28 added this pull request to the merge queue Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #12285 (bae7954) into main (a61b5aa) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 3.12%.

@@            Coverage Diff             @@
##             main   #12285      +/-   ##
==========================================
- Coverage   69.99%   69.99%   -0.01%     
==========================================
  Files        1404     1406       +2     
  Lines      234845   234909      +64     
==========================================
+ Hits       164383   164422      +39     
- Misses      70462    70487      +25     
Flag Coverage Δ
rust 69.99% <3.12%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._catalog/rw_catalog/rw_hummock_pinned_snapshots.rs 0.00% <0.00%> (ø)
...m_catalog/rw_catalog/rw_hummock_pinned_versions.rs 0.00% <0.00%> (ø)
src/frontend/src/meta_client.rs 0.00% <0.00%> (ø)
src/frontend/src/test_utils.rs 74.70% <0.00%> (-0.66%) ⬇️
src/frontend/src/catalog/system_catalog/mod.rs 94.34% <100.00%> (+0.04%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 857a20e Sep 13, 2023
32 of 33 checks passed
@zwang28 zwang28 deleted the wangzheng/sql branch September 13, 2023 13:55
TennyZhuang pushed a commit that referenced this pull request Sep 13, 2023
…og (#12285)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@zwang28 zwang28 removed the user-facing-changes Contains changes that are visible to users label Sep 14, 2023
@zwang28
Copy link
Contributor Author

zwang28 commented Sep 14, 2023

Let's add document after finishing #8612 completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants