Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump aws sdk #13635

Merged
merged 17 commits into from
Nov 27, 2023
Merged

chore: bump aws sdk #13635

merged 17 commits into from
Nov 27, 2023

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Nov 24, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #13584 btw

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx self-assigned this Nov 24, 2023
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx marked this pull request as ready for review November 24, 2023 06:04
@MrCroxx MrCroxx requested a review from a team as a code owner November 24, 2023 06:04
@MrCroxx MrCroxx requested a review from hzxa21 November 24, 2023 06:04
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that the sdk is finally releasing 1.0 version :)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Nov 24, 2023

Blocked by awslabs/aws-sdk-rust#973

@MrCroxx MrCroxx added this pull request to the merge queue Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (14ee693) 68.18% compared to head (029efb2) 68.18%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/object_store/src/object/s3.rs 0.00% 27 Missing ⚠️
...onnector/src/source/filesystem/s3/source/reader.rs 0.00% 4 Missing ⚠️
src/object_store/src/object/error.rs 0.00% 3 Missing ⚠️
src/connector/src/source/filesystem/file_common.rs 0.00% 2 Missing ⚠️
...rc/connector/src/source/filesystem/s3_v2/lister.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13635      +/-   ##
==========================================
- Coverage   68.18%   68.18%   -0.01%     
==========================================
  Files        1522     1522              
  Lines      261746   261761      +15     
==========================================
+ Hits       178482   178483       +1     
- Misses      83264    83278      +14     
Flag Coverage Δ
rust 68.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx removed this pull request from the merge queue due to a manual request Nov 27, 2023
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit d91482b Nov 27, 2023
32 of 33 checks passed
@MrCroxx MrCroxx deleted the xx/bump-aws-sdk-v2 branch November 27, 2023 09:35
@hzxa21
Copy link
Collaborator

hzxa21 commented Nov 27, 2023

Blocked by awslabs/aws-sdk-rust#973

Thanks for digging out the bug in the sdk side 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: performance spike without recovery or s3 failure
5 participants