Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support cursor. #15180

Merged
merged 46 commits into from
Apr 18, 2024
Merged

feat(frontend): support cursor. #15180

merged 46 commits into from
Apr 18, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Feb 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

support cursor for subscription queue, We can create and fetch it, like

create table t1(v1 int, v2 int, v3 int);
insert into t1 values(1,1,1);
create subscription sub from t1 with (retention = '1D');

declare cur subscription cursor for sub;

fetch next from cur =>    

rw_timestamp   | op | v1 | v2 | v3
------------------+----+----+----+----
          |  1 |  1 |  1 |  1

update t1 set v3 = 10 where v1 = 1;

fetch next from cur => 
   rw_timestamp   | op | v1 | v2 | v3
------------------+----+----+----+----
 1711527245871 |  4 |  1 |  1 |  1

fetch next from cur => 
   rw_timestamp   | op | v1 | v2 | v3
------------------+----+----+----+----
 1711527245871 |  3 |  1 |  1 | 10
(1 row)

op = 1 insert
op = 2 delete
op = 3 update_insert
op = 4 update_insert

about since :
since now()/proctime(). crate cursor since now;
without since. create cursor with snapshot
since begin(). create cursor since logstore's begin
since unix_ms. create cursor since unix_ms. now - subscription's retention <= unix_ms <= now

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

gitguardian bot commented Feb 21, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password dc202eb ci/scripts/regress-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@xxhZs xxhZs marked this pull request as ready for review March 20, 2024 11:04
@xxhZs
Copy link
Contributor Author

xxhZs commented Mar 21, 2024

The conflict has been resolved and this pr is ready for review!

@xxhZs xxhZs force-pushed the xxh/add_curser branch 2 times, most recently from f5a0228 to a7db668 Compare April 17, 2024 07:19
fmt

fix ci

fix
@xxhZs xxhZs enabled auto-merge April 17, 2024 09:35
@xxhZs xxhZs added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@xxhZs xxhZs enabled auto-merge April 17, 2024 10:35
@xxhZs xxhZs added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
fix ci

fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants