Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): make blocking sink default + support background sink #16249
feat(meta): make blocking sink default + support background sink #16249
Changes from all commits
d891421
fc4ca1a
6694567
572fd3d
790382e
48852a5
54465a8
9b12266
80ca418
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this path still necessary? Can we now simply treat sinks like materialized views?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose so. But it will require more refactoring of code.
Sink is unique from materialized view in that the output will immediately be visible, since it's external to the stream job.
For materialized views, we have to do something extra, which is to hide the output until backfill is complete.
As such we persist materialized views twice, when they undergo background ddl:
Creating
, i.e. invisible, but recoverable).Finished
, i.e. visible).For sink we can immediately mark it as
Finished
(i.e. just step 2), we can't do that for MVs.For Index, we have to also go through the same flow as materialized view. When I support
Index
I will also review to see if Sink can be supported likewise and unify more branches of code.For now I think this is acceptable approach which requires least changes, and with simple concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting to realize. 😄