Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): change streaming_rate_limit=0 to pause stream instead of disable rate limit #16333

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Apr 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support rate limit 0. Its behaviour is to pause the backfill / source stream.

Subsequent PR will add ALTER MV with (enable_streaming_rate_limit=false), so we can also test it in deterministic tests.

To disable rate limit use streaming_rate_limit=default instead.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

  1. set streaming_rate_limit=0 now means pausing the snapshot read stream for backfill, pausing source read for sources. It previously disabled rate limit within the session.
  2. set streaming_rate_limit=default will disable rate limit within the session. It does not alter existing DDLs' rate limits.

@kwannoel kwannoel added the user-facing-changes Contains changes that are visible to users label Apr 16, 2024
@kwannoel kwannoel changed the title feat(frontend): support rate_limit=0 feat(frontend): change streaming_rate_limit=0 to pause stream instead of disable rate limit Apr 16, 2024
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I forgot there is still some work to do in the frontend.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwannoel kwannoel added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@kwannoel kwannoel force-pushed the kwannoel/rate-limit-0 branch 2 times, most recently from 88edf09 to 9ec740d Compare April 18, 2024 00:34
;
@kwannoel kwannoel enabled auto-merge April 18, 2024 02:41
@kwannoel kwannoel added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit ebf0104 Apr 18, 2024
27 of 28 checks passed
@kwannoel kwannoel deleted the kwannoel/rate-limit-0 branch April 18, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants