fix(streaming): avoid violating the assumption of U+ after U- in hash join & add checker #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
skyzh
approved these changes
Apr 13, 2022
| } | ||
|
|
||
| #[async_trait] | ||
| impl super::DebugExecutor for UpdateCheckExecutor { |
There was a problem hiding this comment.
Can we merge all debug executors into one? The backtrace would be disaster...
|
also test failed |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Codecov Report
@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 71.33% 71.35% +0.02%
==========================================
Files 605 606 +1
Lines 79168 79261 +93
==========================================
+ Hits 56475 56558 +83
- Misses 22693 22703 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
yuhao-su
approved these changes
Apr 13, 2022
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
When there're multiple rows matched with a single
UpdateDelete, the hash join executor will yield multiple continuousUpdateDeletes, which violates the assumption of U+ after U- used byMerge,Filterand so on. One can simply reproduce this in tpch q17, q18 with rearranged chain in #1556 since it introduces more barriers than before.Checklist
Refer to a related PR or issue link (optional)
U+U-appears in pairs #1801