Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(streaming): switch to rearranged chain & remove no-cache e2e #1838

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Apr 14, 2022

Signed-off-by: Bugen Zhao i@bugenzhao.com

What's changed and what's your intention?

As title. After #1556 and #1811 is merged, let's see whether we can successfully switch to RearrangedChain. 馃槩

This PR also removes no-cache e2e tests since all of the executor v2s are not able to clear cache now. Besides, the clear-cache of v1 HashJoin has also been disabled due to known issues in #1540.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@skyzh
Copy link
Contributor

skyzh commented Apr 14, 2022

Better to re-run CI for at least 5 times 馃お

@BugenZhao
Copy link
Member Author

Better to re-run CI for at least 5 times 馃お

It's hard to tell whether there're other bugs that rearranged chain will expose. 馃い

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1838 (ce92fb9) into main (c1c7440) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   70.86%   70.86%   -0.01%     
==========================================
  Files         609      609              
  Lines       79632    79632              
==========================================
- Hits        56431    56428       -3     
- Misses      23201    23204       +3     
Flag Coverage 螖
rust 70.86% <酶> (-0.01%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
src/stream/src/executor_v2/mod.rs 65.21% <酶> (酶)
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) 猬囷笍
.../src/executor/managed_state/aggregation/extreme.rs 89.89% <0.00%> (-0.27%) 猬囷笍

馃摚 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao changed the title chore(streaming): switch to rearranged chain chore(streaming): switch to rearranged chain & remove no-cache e2e Apr 14, 2022
@BugenZhao BugenZhao enabled auto-merge (squash) April 14, 2022 09:43
@BugenZhao BugenZhao merged commit 4b4f7f6 into main Apr 14, 2022
@BugenZhao BugenZhao deleted the bz/switch-to-rearranged-chain branch April 14, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants