Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): remove AggStateError variant and more #3140

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jun 11, 2022

What's changed and what's your intention?

As title. 😄

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #3140 (be31f07) into main (97177a9) will increase coverage by 0.00%.
The diff coverage is 69.17%.

@@           Coverage Diff           @@
##             main    #3140   +/-   ##
=======================================
  Coverage   73.51%   73.51%           
=======================================
  Files         737      737           
  Lines      101665   101650   -15     
=======================================
- Hits        74735    74725   -10     
+ Misses      26930    26925    -5     
Flag Coverage Δ
rust 73.51% <69.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/error.rs 66.66% <0.00%> (ø)
src/stream/src/executor/batch_query.rs 91.42% <ø> (ø)
src/stream/src/executor/hop_window.rs 84.18% <ø> (ø)
src/stream/src/executor/lookup/impl_.rs 95.58% <ø> (ø)
src/stream/src/executor/mview/materialize.rs 89.51% <ø> (ø)
src/stream/src/executor/error.rs 5.40% <19.04%> (+5.40%) ⬆️
src/stream/src/executor/aggregation/mod.rs 94.96% <28.57%> (+0.66%) ⬆️
...ream/src/executor/managed_state/aggregation/mod.rs 83.54% <50.00%> (+2.06%) ⬆️
src/stream/src/executor/aggregation/row_count.rs 78.72% <66.66%> (ø)
src/stream/src/executor/aggregation/foldable.rs 88.18% <72.50%> (+0.07%) ⬆️
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@lmatz lmatz merged commit 5922133 into main Jun 11, 2022
@lmatz lmatz deleted the bz/remove-agg-state-error-variant branch June 11, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AggStateError(RwError) variant in stream executor error.
3 participants