Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stream): remove TopNStateError #3142

Merged
merged 1 commit into from
Jun 12, 2022
Merged

refactor(stream): remove TopNStateError #3142

merged 1 commit into from
Jun 12, 2022

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 11, 2022

What's changed and what's your intention?

Similar to #3140.

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests

  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

closes #3134

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #3142 (2bf1db1) into main (5922133) will increase coverage by 0.00%.
The diff coverage is 78.16%.

@@           Coverage Diff           @@
##             main    #3142   +/-   ##
=======================================
  Coverage   73.51%   73.52%           
=======================================
  Files         737      737           
  Lines      101650   101632   -18     
=======================================
- Hits        74725    74720    -5     
+ Misses      26925    26912   -13     
Flag Coverage Δ
rust 73.52% <78.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/error.rs 5.63% <ø> (+0.22%) ⬆️
src/stream/src/executor/top_n.rs 91.58% <40.00%> (+0.54%) ⬆️
src/stream/src/executor/top_n_appendonly.rs 95.16% <50.00%> (+0.69%) ⬆️
...ecutor/managed_state/top_n/top_n_bottom_n_state.rs 77.63% <94.44%> (+0.66%) ⬆️
src/stream/src/executor/managed_state/top_n/mod.rs 100.00% <100.00%> (ø)
...am/src/executor/managed_state/top_n/top_n_state.rs 93.02% <100.00%> (+0.25%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lmatz lmatz marked this pull request as ready for review June 11, 2022 14:37
@lmatz lmatz requested a review from BugenZhao June 12, 2022 02:06
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BugenZhao BugenZhao merged commit 3acee84 into main Jun 12, 2022
@BugenZhao BugenZhao deleted the lz/remove branch June 12, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TopNStateError(RwError) variant in stream executor error.
2 participants