Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor create state table code + fix incorrect arguments #3190

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Jun 14, 2022

What's changed and what's your intention?

It was bug introduced by incorrect arguments (My bad)...

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3190 (edf888f) into main (6d98333) will decrease coverage by 0.00%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main    #3190      +/-   ##
==========================================
- Coverage   73.57%   73.56%   -0.01%     
==========================================
  Files         744      744              
  Lines      102180   102202      +22     
==========================================
+ Hits        75174    75182       +8     
- Misses      27006    27020      +14     
Flag Coverage Δ
rust 73.56% <97.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/aggregation/mod.rs 92.55% <95.83%> (-2.41%) ⬇️
src/stream/src/executor/global_simple_agg.rs 96.06% <100.00%> (-0.02%) ⬇️
src/stream/src/executor/hash_agg.rs 97.61% <100.00%> (-0.01%) ⬇️
src/meta/src/hummock/mock_hummock_meta_client.rs 42.39% <0.00%> (-1.09%) ⬇️
src/storage/src/table/cell_based_table.rs 69.77% <0.00%> (-0.82%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️
src/storage/src/hummock/local_version_manager.rs 84.12% <0.00%> (-0.16%) ⬇️
src/meta/src/barrier/mod.rs 69.45% <0.00%> (+0.32%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BowenXiao1999 BowenXiao1999 requested a review from skyzh June 14, 2022 03:52
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, which bug does this PR fix?

src/stream/src/executor/aggregation/mod.rs Outdated Show resolved Hide resolved
vec![
// Now we only infer order type for min/max in a naive way.
if agg_call.kind == AggKind::Max {
OrderType::Descending
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please help check how we encode stream pk previously? For max agg, did we also encode pk in descending way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean write batch/keyspace? I think after this PR, as long as we are using state table, we are encode pk in correct order way.

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
@BowenXiao1999 BowenXiao1999 merged commit 43f899b into main Jun 14, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw/refactor-fix-create-state-table-code branch June 14, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants