-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor create state table code + fix incorrect arguments #3190
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3190 +/- ##
==========================================
- Coverage 73.57% 73.56% -0.01%
==========================================
Files 744 744
Lines 102180 102202 +22
==========================================
+ Hits 75174 75182 +8
- Misses 27006 27020 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, which bug does this PR fix?
vec![ | ||
// Now we only infer order type for min/max in a naive way. | ||
if agg_call.kind == AggKind::Max { | ||
OrderType::Descending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please help check how we encode stream pk previously? For max agg, did we also encode pk in descending way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean write batch/keyspace? I think after this PR, as long as we are using state table, we are encode pk in correct order way.
Co-authored-by: Bugen Zhao <i@bugenzhao.com>
What's changed and what's your intention?
It was bug introduced by incorrect arguments (My bad)...
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)