refactor(state_table): simplify interface of insert / delete #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3238 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 745 745
Lines 101868 101857 -11
=======================================
- Hits 74563 74556 -7
+ Misses 27305 27301 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
3 tasks
BugenZhao
reviewed
Jun 15, 2022
Comment on lines
194
to
197
| match TOP_N_TYPE { | ||
| TOP_N_MIN => self.state_table.insert::<false>(value.clone())?, | ||
| TOP_N_MAX => self.state_table.insert::<true>(value.clone())?, | ||
| TOP_N_MIN => self.state_table.insert(value.clone())?, | ||
| TOP_N_MAX => self.state_table.insert(value.clone())?, | ||
| _ => unreachable!(), |
Comment on lines
-229
to
+245
| TOP_N_MIN => self.state_table.delete::<false>(value)?, | ||
| TOP_N_MAX => self.state_table.delete::<true>(value)?, | ||
| TOP_N_MIN => self.state_table.delete(value)?, | ||
| TOP_N_MAX => self.state_table.delete(value)?, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As title
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
close #3232