-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storage): do not aware of keyspace in state table #3239
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make Keyspace::prefixed_key
private?
Codecov Report
@@ Coverage Diff @@
## main #3239 +/- ##
==========================================
+ Coverage 73.18% 73.22% +0.03%
==========================================
Files 745 745
Lines 101845 101783 -62
==========================================
- Hits 74540 74532 -8
+ Misses 27305 27251 -54
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
May conflict with #3238. |
…le-prefix Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look much better!
We're still using it in |
Signed-off-by: Bugen Zhao i@bugenzhao.com
What's changed and what's your intention?
With the
prefixed_range
introduced in #3217, we can make the cell-based table & state table not aware of keyspace prefix with ease.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)