Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): remove source limit for concurrent ckpt #3424

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 23, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Should be merged after concurrent checkpoint. Remove source limit.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3403

@skyzh skyzh requested a review from xxhZs June 23, 2022 07:07
@skyzh skyzh force-pushed the skyzh/remove-source-limit-2 branch from 1ad2874 to 9791abc Compare June 23, 2022 07:08
@tabVersion
Copy link
Contributor

is the backpressure mechanism not necessary now?

@tabVersion tabVersion self-requested a review June 23, 2022 07:11
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3424 (fa1b0e6) into main (84f84dc) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3424   +/-   ##
=======================================
  Coverage   73.81%   73.81%           
=======================================
  Files         765      765           
  Lines      105357   105357           
=======================================
+ Hits        77766    77769    +3     
+ Misses      27591    27588    -3     
Flag Coverage Δ
rust 73.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/source.rs 95.37% <ø> (ø)
src/storage/src/hummock/local_version_manager.rs 84.53% <0.00%> (+0.15%) ⬆️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.25%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor Author

skyzh commented Jun 23, 2022

is the backpressure mechanism not necessary now?

This is not related to back pressure, IMO.

@hzxa21
Copy link
Collaborator

hzxa21 commented Jun 23, 2022

@skyzh #3415 is merged. We can resolve the conflict and merge this PR now.

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh force-pushed the skyzh/remove-source-limit-2 branch from 9791abc to 557fb55 Compare June 23, 2022 09:05
@skyzh skyzh marked this pull request as ready for review June 23, 2022 09:05
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 23, 2022
@mergify mergify bot merged commit f1c7a2d into main Jun 23, 2022
@mergify mergify bot deleted the skyzh/remove-source-limit-2 branch June 23, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streaming: remove source limit
3 participants