Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix register leader info after meta reboot #3428

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jun 23, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
  • Add the 'user-facing changes' label if your PR contains changes that are visible to users (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Resolve #3398

@yezizp2012 yezizp2012 marked this pull request as ready for review June 23, 2022 08:35
@github-actions github-actions bot added the type/fix Bug fix label Jun 23, 2022
@yezizp2012 yezizp2012 requested a review from zwang28 June 23, 2022 08:35
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3428 (a779f45) into main (be644d1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
- Coverage   73.81%   73.81%   -0.01%     
==========================================
  Files         765      765              
  Lines      105351   105356       +5     
==========================================
- Hits        77766    77765       -1     
- Misses      27585    27591       +6     
Flag Coverage Δ
rust 73.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/rpc/server.rs 0.00% <0.00%> (ø)
src/frontend/src/expr/utils.rs 98.74% <0.00%> (-0.51%) ⬇️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 23, 2022
@mergify mergify bot merged commit 1e4ae7a into main Jun 23, 2022
@mergify mergify bot deleted the fix/fix-register-leader branch June 23, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta restart fail due to panic on keep lease failed, another node has become new leader
2 participants