-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): iterate with a range of vnodes using merge sort in cell-based table #3433
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #3433 +/- ##
=======================================
Coverage 73.73% 73.74%
=======================================
Files 767 768 +1
Lines 105683 105736 +53
=======================================
+ Hits 77928 77976 +48
- Misses 27755 27760 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. This PR only implements the merge-sort iterator and it's still unused since the vnode always fall back to
0x00
for now. We need to tweak the stateful executors one by one to enable that.Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)