Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): iterate with a range of vnodes using merge sort in cell-based table #3433

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. This PR only implements the merge-sort iterator and it's still unused since the vnode always fall back to 0x00 for now. We need to tweak the stateful executors one by one to enable that.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@BugenZhao BugenZhao requested review from skyzh, fuyufjh, wcy-fdu and xx01cyx and removed request for skyzh June 23, 2022 10:03
Copy link
Contributor

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #3433 (8db9dc2) into main (e23db9f) will increase coverage by 0.00%.
The diff coverage is 87.27%.

@@           Coverage Diff           @@
##             main    #3433   +/-   ##
=======================================
  Coverage   73.73%   73.74%           
=======================================
  Files         767      768    +1     
  Lines      105683   105736   +53     
=======================================
+ Hits        77928    77976   +48     
- Misses      27755    27760    +5     
Flag Coverage Δ
rust 73.74% <87.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/table/cell_based_table.rs 70.86% <0.00%> (ø)
...c/storage/src/table/cell_based_table/iter_utils.rs 87.75% <87.75%> (ø)
src/storage/src/table/state_table.rs 95.86% <100.00%> (+0.11%) ⬆️
src/frontend/src/expr/utils.rs 99.24% <0.00%> (+0.25%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/storage/src/table/cell_based_table/iter_utils.rs Outdated Show resolved Hide resolved
@BugenZhao BugenZhao added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 24, 2022
@mergify mergify bot merged commit 93e02e7 into main Jun 24, 2022
@mergify mergify bot deleted the bz/vnode-in-key-part-4 branch June 24, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support scanning and iterating with a range of vnodes using merge sort
3 participants