feat(storage): hummock support ttl ability with compaction_filter #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Li0k
force-pushed
the
li0k/feat_table_option_for_compaction_group
branch
from
032c782
to
ccd14ad
Compare
Li0k
force-pushed
the
li0k/feat_hummock_ttl_compactin
branch
from
9f66533
to
ec9c2d7
Compare
Li0k
force-pushed
the
li0k/feat_table_option_for_compaction_group
branch
from
ccd14ad
to
c8de7ba
Compare
Base automatically changed from
li0k/feat_table_option_for_compaction_group
to
main
June 24, 2022 07:14
Li0k
force-pushed
the
li0k/feat_hummock_ttl_compactin
branch
from
ec9c2d7
to
bee1f68
Compare
src/storage/src/hummock/compactor.rs
Outdated
| match table_id { | ||
| Some(table_id) => { | ||
| let ttl = self.table_id_to_ttl[&table_id]; | ||
| let epoch = get_epoch(key); |
There was a problem hiding this comment.
Get epoch and table_id in once call for performance
There was a problem hiding this comment.
shall we need a new function to get epoch and table_id in once call ? (not exist now)
fn extract_table_id_and_epoch(full_key: &[u8]) -> (Option<u32>, Epoch)in this case it means that we no need to get_epoch if table_id not exist
There was a problem hiding this comment.
yes. A new function.
Li0k
force-pushed
the
li0k/feat_hummock_ttl_compactin
branch
2 times, most recently
from
3df6c68
to
5244321
Compare
Codecov Report
@@ Coverage Diff @@
## main #3438 +/- ##
==========================================
+ Coverage 74.37% 74.42% +0.04%
==========================================
Files 769 769
Lines 107047 107270 +223
==========================================
+ Hits 79621 79838 +217
- Misses 27426 27432 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fix(storage): fix cargo.toml
Li0k
force-pushed
the
li0k/feat_hummock_ttl_compactin
branch
from
5244321
to
c1719bb
Compare
Li0k
added
mergify/can-merge
Li0k
added
the
mergify/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
hummock support ttl ability with compaction_filter
Checklist
Refer to a related PR or issue link (optional)