feat(storage): use STATE_CLEAN and TTL as default compaction_filter_mask #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
approved these changes
Jun 27, 2022
Li0k
force-pushed
the
li0k/feat_compaction_filter_mask
branch
3 times, most recently
from
8c2b786
to
298331c
Compare
Codecov Report
@@ Coverage Diff @@
## main #3482 +/- ##
=======================================
Coverage 74.44% 74.44%
=======================================
Files 768 768
Lines 107557 107557
=======================================
Hits 80073 80073
Misses 27484 27484
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
hzxa21
reviewed
Jun 27, 2022
| Self { | ||
| ttl: table_option.ttl, | ||
| } | ||
| let ttl = if table_option.ttl == 0 { |
There was a problem hiding this comment.
fix it with a constant value
i gonna unifty the constant value define in other pr (in constant::hummock mod)
Li0k
force-pushed
the
li0k/feat_compaction_filter_mask
branch
from
298331c
to
e9b4fdd
Compare
Li0k
added
the
mergify/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
[ ] I have written necessary docs and comments[ ] I have added necessary unit tests and integration testsRefer to a related PR or issue link (optional)