Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): support idle exit #3444

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

breezewish
Copy link
Contributor

@breezewish breezewish commented Jun 24, 2022

Signed-off-by: Wish breezewish@outlook.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds dangerous_max_idle_secs to the meta server args. When specified, meta server will be exited after specified idle duration (idle is defined as no mview creation, deletion or flush). This can be useful for the local playground or online playground.

The single-node playground will be also exited in this case, bringing other service down. Playground opt max-idle-secs-to-exit in risedev.yml will be passed to the meta server.

Note: multi-node playground currently does not fully exit at idle, as other service are still keep retrying.

To try with locally:

  playground:
    - use: meta-node
      enable-dashboard-v2: false
      unsafe-disable-recovery: true
      max-idle-secs-to-exit: 10   # <-- Specify idle exit duration
    - use: compute-node
    - use: frontend

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Wish <breezewish@outlook.com>
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Wish <breezewish@outlook.com>
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3444 (d3eee3e) into main (68be229) will decrease coverage by 0.04%.
The diff coverage is 33.12%.

@@            Coverage Diff             @@
##             main    #3444      +/-   ##
==========================================
- Coverage   73.77%   73.73%   -0.05%     
==========================================
  Files         766      767       +1     
  Lines      105550   105683     +133     
==========================================
+ Hits        77874    77925      +51     
- Misses      27676    27758      +82     
Flag Coverage Δ
rust 73.73% <33.12%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/meta/src/barrier/mod.rs 81.19% <0.00%> (ø)
src/meta/src/cluster/mod.rs 59.58% <0.00%> (ø)
src/meta/src/lib.rs 1.20% <0.00%> (-0.10%) ⬇️
src/meta/src/rpc/server.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/ddl_service.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/service_config.rs 0.00% <ø> (ø)
src/risedevtool/src/task/meta_node_service.rs 0.00% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants