-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): support idle exit #3444
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Wish <breezewish@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
- Coverage 73.77% 73.73% -0.05%
==========================================
Files 766 767 +1
Lines 105550 105683 +133
==========================================
+ Hits 77874 77925 +51
- Misses 27676 27758 +82
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Wish breezewish@outlook.com
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds
dangerous_max_idle_secs
to the meta server args. When specified, meta server will be exited after specified idle duration (idle is defined as no mview creation, deletion or flush). This can be useful for the local playground or online playground.The single-node playground will be also exited in this case, bringing other service down. Playground opt
max-idle-secs-to-exit
inrisedev.yml
will be passed to the meta server.Note: multi-node playground currently does not fully exit at idle, as other service are still keep retrying.
To try with locally:
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)