Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(risedev): Add a profile for the online playground #3446

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

breezewish
Copy link
Contributor

@breezewish breezewish commented Jun 24, 2022

Signed-off-by: Wish breezewish@outlook.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Utilize #3444 for the online playground docker image.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#3444

Signed-off-by: Wish <breezewish@outlook.com>
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

online-docker-playground:
- use: meta-node
enable-dashboard-v2: false
unsafe-disable-recovery: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should remove this line so that we can enable recovery?

@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3446 (c8c3bdb) into main (ab138d2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3446   +/-   ##
=======================================
  Coverage   73.73%   73.73%           
=======================================
  Files         767      767           
  Lines      105683   105683           
=======================================
+ Hits        77927    77929    +2     
+ Misses      27756    27754    -2     
Flag Coverage Δ
rust 73.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/local_version_manager.rs 84.53% <0.00%> (+0.15%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 41.50% <0.00%> (+0.94%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit e23db9f into risingwavelabs:main Jun 24, 2022
@breezewish breezewish deleted the online-playground-profile branch June 24, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants