feat(streaming): enable consistent hash for hash agg #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
commented
Jun 29, 2022
| @@ -129,21 +129,22 @@ impl<S: StateStore, SER: RowSerializer> CellBasedTableBase<S, SER, READ_ONLY> { | |||
| /// set of `column_ids`. The output will only contains columns with the given ids in the same | |||
| /// order. | |||
| /// This is parameterized on cell based row serializer. | |||
| // TODO: allow specifying the distribution keys and vnodes. | |||
There was a problem hiding this comment.
CellBasedTable is directly constructed only in batch query executor or seq scan. We leave them untouched, while specifying vnodes and dist keys for streaming-purpose StateTable is implemented in this PR.
Codecov Report
@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
+ Coverage 74.44% 74.45% +0.01%
==========================================
Files 770 770
Lines 108409 108455 +46
==========================================
+ Hits 80703 80749 +46
Misses 27706 27706
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added
the
mergify/can-merge
5 tasks
|
Hey @BugenZhao, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
* allow passing vnodes Signed-off-by: Bugen Zhao <i@bugenzhao.com> * enable distribution for hash agg Signed-off-by: Bugen Zhao <i@bugenzhao.com> * fix datum hash Signed-off-by: Bugen Zhao <i@bugenzhao.com> * debug Signed-off-by: Bugen Zhao <i@bugenzhao.com> * clean up Signed-off-by: Bugen Zhao <i@bugenzhao.com> * fix state table generation Signed-off-by: Bugen Zhao <i@bugenzhao.com> * remove logs and refine docs Signed-off-by: Bugen Zhao <i@bugenzhao.com> * refine fallback vnodes doc Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR enables consistent hash for hash agg. The assertions in
CellBasedTableshows that we've correctly sharded data with hash dispatcher.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
StreamNode::HashAggshould be group key #3456Hashimplementation onDatumis not consistent withArray::hash_at#3457