refactor(simple-agg): use fe generated table catalog for simple agg + some code-reuse refactor #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BowenXiao1999
force-pushed
the
bw/simple_agg_fe_infer
branch
from
1ed4393
to
31e7673
Compare
Codecov Report
@@ Coverage Diff @@
## main #3514 +/- ##
=======================================
Coverage 74.48% 74.49%
=======================================
Files 771 771
Lines 108317 108342 +25
=======================================
+ Hits 80684 80709 +25
Misses 27633 27633
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
6 tasks
BugenZhao
reviewed
Jun 29, 2022
| // Create state tables for each agg call. | ||
| let mut state_tables = Vec::with_capacity(agg_calls.len()); | ||
| for (agg_call, ks) in agg_calls.iter().zip_eq(&keyspace) { | ||
| state_tables.push(generate_state_table( |
There was a problem hiding this comment.
Can we remove generate_state_table now?
There was a problem hiding this comment.
It's now only used in unit test. For test, the CN still infer it by itself. I should add a test only tag.
There was a problem hiding this comment.
Emmm I do not find one. Moved them all to test_utils.rs
BowenXiao1999
force-pushed
the
bw/simple_agg_fe_infer
branch
from
31e7673
to
d64b51a
Compare
BowenXiao1999
added
the
mergify/can-merge
3 tasks
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
… some code-reuse refactor (#3514) * refactor(simple-agg): use fe generated table catalog for simple agg and some simple refactor * move generate_state_table to test mod (test only) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd some simple refactor
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
generate_state_table_from_proto. Currently reused by global agg and simple agg.new_boxed_simple_agg_executor. Currently used by tests in simple agg.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)