Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rt): support tokio-console tracing #3461

Merged
merged 5 commits into from
Jul 2, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 25, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #3461 (85a7b34) into main (bf7ce03) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3461      +/-   ##
==========================================
- Coverage   74.33%   74.30%   -0.04%     
==========================================
  Files         773      773              
  Lines      109358   109399      +41     
==========================================
- Hits        81289    81286       -3     
- Misses      28069    28113      +44     
Flag Coverage Δ
rust 74.30% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/bin/compactor.rs 16.66% <0.00%> (ø)
src/cmd/src/bin/compute_node.rs 13.33% <0.00%> (-3.34%) ⬇️
src/cmd/src/bin/ctl.rs 15.38% <0.00%> (ø)
src/cmd/src/bin/frontend_node.rs 16.66% <0.00%> (ø)
src/cmd/src/bin/meta_node.rs 16.66% <0.00%> (ø)
src/cmd_all/src/bin/risingwave.rs 1.61% <0.00%> (-0.13%) ⬇️
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/utils/runtime/src/lib.rs 0.60% <0.00%> (ø)
src/utils/runtime/src/trace_runtime.rs 0.00% <ø> (ø)
src/meta/src/hummock/mock_hummock_meta_client.rs 40.56% <0.00%> (-0.95%) ⬇️
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh
Copy link
Contributor Author

skyzh commented Jun 25, 2022

Developers need to first enable tokio console in related components:

image

Then it will automatically work!

image

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

skyzh added 2 commits July 2, 2022 13:58
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh force-pushed the skyzh/tokio-console-tracing branch from 9554e5b to 93d223e Compare July 2, 2022 05:58
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jul 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2022

Hey @skyzh, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue. More details can be found on the Queue: Embarked in merge train check-run.

@skyzh
Copy link
Contributor Author

skyzh commented Jul 2, 2022

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2022

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@skyzh skyzh added mergify/can-merge Indicates that the PR can be added to the merge queue and removed mergify/can-merge Indicates that the PR can be added to the merge queue labels Jul 2, 2022
@mergify mergify bot merged commit 9d99aa5 into main Jul 2, 2022
@mergify mergify bot deleted the skyzh/tokio-console-tracing branch July 2, 2022 10:02
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* feat(rt): support tokio-console tracing

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* fix check

Signed-off-by: Alex Chi <iskyzh@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* feat(rt): support tokio-console tracing

Signed-off-by: Alex Chi <iskyzh@gmail.com>

* fix check

Signed-off-by: Alex Chi <iskyzh@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants