chore(utils): improve readability #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Russell <git@ryanrussell.org>
Codecov Report
@@ Coverage Diff @@
## main #3465 +/- ##
=======================================
Coverage 74.31% 74.31%
=======================================
Files 769 769
Lines 106773 106773
=======================================
Hits 79347 79347
Misses 27426 27426
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
TennyZhuang
approved these changes
Jun 26, 2022
mergify bot
added a commit
that referenced
this pull request
Jun 30, 2022
* feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> * Update arithmetic_op.rs * Update arithmetic_op.rs * test: sqlsmith supports generating unary func (#3370) * test: sqlsmith supports generating unary func (#3370) * chore(utils): improve readability (#3465) Signed-off-by: Ryan Russell <git@ryanrussell.org> * chore(utils): improve readability (#3465) Signed-off-by: Ryan Russell <git@ryanrussell.org> * feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> Co-authored-by: Tao Wu <wutao@singularity-data.com> Co-authored-by: Ryan Russell <ryanrussell@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
* feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> * Update arithmetic_op.rs * Update arithmetic_op.rs * test: sqlsmith supports generating unary func (#3370) * test: sqlsmith supports generating unary func (#3370) * chore(utils): improve readability (#3465) Signed-off-by: Ryan Russell <git@ryanrussell.org> * chore(utils): improve readability (#3465) Signed-off-by: Ryan Russell <git@ryanrussell.org> * feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> * feat(expr): support some date/time ops Signed-off-by: Shmiwy <wyf000219@126.com> Co-authored-by: Tao Wu <wutao@singularity-data.com> Co-authored-by: Ryan Russell <ryanrussell@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Russell git@ryanrussell.org
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
More code readability improvements focused in the
/src/utilspathChecklist
./risedev check(or alias,./risedev c)