Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): warn on deterministic test #3468

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Jun 26, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title

Checklist

- [ ] I have written necessary docs and comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #3468 (bc3cc31) into main (7460a47) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3468      +/-   ##
==========================================
- Coverage   74.39%   74.39%   -0.01%     
==========================================
  Files         768      768              
  Lines      107784   107784              
==========================================
- Hits        80185    80182       -3     
- Misses      27599    27602       +3     
Flag Coverage Δ
rust 74.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/manager/id.rs 95.50% <0.00%> (-0.57%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from wangrunji0408 June 27, 2022 07:39
@skyzh skyzh added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 28, 2022
@mergify mergify bot merged commit f1b9a2c into main Jun 28, 2022
@mergify mergify bot deleted the skyzh/warn-deterministic-test branch June 28, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants