Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(streaming): remove RwResult in streaming hash join #3476

Merged
merged 7 commits into from
Jun 29, 2022

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Jun 27, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3476 (f451fcd) into main (62750cd) will increase coverage by 0.01%.
The diff coverage is 87.82%.

@@            Coverage Diff             @@
##             main    #3476      +/-   ##
==========================================
+ Coverage   74.43%   74.44%   +0.01%     
==========================================
  Files         771      771              
  Lines      108446   108464      +18     
==========================================
+ Hits        80718    80746      +28     
+ Misses      27728    27718      -10     
Flag Coverage Δ
rust 74.44% <87.82%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/error.rs 5.88% <ø> (+0.24%) ⬆️
src/stream/src/executor/hash_join.rs 96.85% <81.15%> (+0.02%) ⬆️
src/stream/src/executor/managed_state/join/mod.rs 92.92% <94.44%> (+1.60%) ⬆️
src/common/src/hash/key.rs 84.95% <100.00%> (+0.08%) ⬆️
src/stream/src/common/builder.rs 98.96% <100.00%> (+0.04%) ⬆️
src/stream/src/executor/hash_agg.rs 97.82% <100.00%> (-0.01%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/storage/src/hummock/local_version_manager.rs 79.27% <0.00%> (+0.12%) ⬆️
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@chinawch007
Copy link

Excuse me, what's the meaning of 'degree' in managed_state/join/mod.rs?

@yuhao-su yuhao-su requested a review from BugenZhao June 29, 2022 05:20
@BugenZhao BugenZhao enabled auto-merge (squash) June 29, 2022 05:33
@BugenZhao BugenZhao added the mergify/can-merge Indicates that the PR can be added to the merge queue label Jun 29, 2022
@BugenZhao BugenZhao merged commit 60c6fbf into main Jun 29, 2022
@BugenZhao BugenZhao deleted the remove_hash_join_error branch June 29, 2022 06:01
huangjw806 pushed a commit that referenced this pull request Jul 5, 2022
* remove rwresult in join

* minor

* minor

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants