-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(streaming): remove RwResult in streaming hash join #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3476 +/- ##
==========================================
+ Coverage 74.43% 74.44% +0.01%
==========================================
Files 771 771
Lines 108446 108464 +18
==========================================
+ Hits 80718 80746 +28
+ Misses 27728 27718 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Excuse me, what's the meaning of 'degree' in managed_state/join/mod.rs? |
BugenZhao
reviewed
Jun 29, 2022
…move_hash_join_error
BugenZhao
approved these changes
Jun 29, 2022
BugenZhao
added
the
mergify/can-merge
Indicates that the PR can be added to the merge queue
label
Jun 29, 2022
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
* remove rwresult in join * minor * minor * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
./risedev check
(or alias,./risedev c
)Refer to a related PR or issue link (optional)